Re: [PATCH v3 04/33] gpu: nova-core: firmware: add r000 bindings

From: John Hubbard

Date: Tue Sep 22 2026 - 21:34:19 EST


On 9/21/26 6:51 PM, John Hubbard wrote:
> On 9/18/26 10:42 AM, Timur Tabi wrote:
>> On Thu, 2026-09-17 at 18:06 -0700, John Hubbard wrote:
>>> Nova-core boots the r570 GSP firmware, release 570.144. The GSP firmware
>>> releases from r615 onward share one ABI, and their firmware files carry
>>> no version number in their names, because each image records its version
>>> internally. The driver calls that ABI "r000", so that its name does not
>>> change with each release.
>>>
>>> Add the bindings that bindgen generates from the r000 headers of Open
>>> RM, the open-source NVIDIA kernel driver.
>>
>> You should specify exactly which OpenRM version was used for this, because I suspect that some
>> of these constants might change in future versions. The upcoming NVOC stuff will mitigate that,
>> but it's still useful to be specific, just in case.
>
> Yes, good point. I've verified that the bindgen with the publicly
> released r615 provides the same thing as here--as long as I delete
> one unused item from bindgen input. Which I've done for v4.
>
> I'm about to re-test against stock r615 firmware, which I now realize
> would have been ideal to do earlier. I was feeling less optimistic
> about it at the time, but after looking at some details I think it
> will work for this patchset, just not necessarily for the follow-on
> series that Zhi Wang is posting for full vGPU.
>
Good news, this series boots up on the stock, publicly released r615 firmware,
just fine!

I tested Turing, Ampere and Blackwell GPUs:

PCIe Probe: PASS: Chipset info: all 3 GPUs OK
ok 0000:c1:00.0: NVIDIA (Chipset: TU117, Architecture: Turing, Revision: a.1)
ok 0000:c2:00.0: NVIDIA (Chipset: GB202, Architecture: BlackwellGB20x, Revision: a.1)
ok 0000:01:00.0: NVIDIA (Chipset: GA104, Architecture: Ampere, Revision: a.1)

Interrupt Self-test: PASS: Interrupt self-test: all 3 GPUs OK
ok 0000:c1:00.0: passed, subtree 2, 2 deliveries
ok 0000:c2:00.0: passed, subtree 2, 2 deliveries
ok 0000:01:00.0: passed, subtree 2, 2 deliveries

Get GPU Name: PASS: GPU name: all 3 GPUs OK
ok 0000:c1:00.0: NVIDIA T400 4GB
ok 0000:c2:00.0: NVIDIA RTX PRO 6000 Blackwell Max-Q Workstation Edition
ok 0000:01:00.0: NVIDIA RTX A4000


thanks,
--
John Hubbard