Re: [PATCH] PCI: rcar-gen4: Fix device_node leak in rcar_gen4_pcie_host_msi_addr()

[Fuad Tabba]

Hi Marek,

On Tue, 22 Sept 2026 at 19:07, Marek Vasut <marek.vasut@xxxxxxxxxxx> wrote:
[...]
> Oh, this is very nice, TIL, thank you.
>
> Reviewed-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> Tested-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx> # Retronix
> R-Car V4H Sparrow Hawk

Thanks.

>
> >> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> >
> > [...]
> >
> >> "
> >>
> >> Also, I think drivers/pci/controller/pcie-iproc.c
> >> iproc_pcie_msi_enable() needs similar fix ?
> >
> > I don't think so: iproc_pcie_msi_enable() already puts the node at out_put_node, on the steer failure and the success paths alike.
>
> Could you maybe send similar simplification patch ?

Sure: https://lore.kernel.org/all/20260922210839.3765444-1-fuad.tabba@xxxxxxxxx/

Cheers,
/fuad

>
> Thank you !
>
> --
> Best regards,
> Marek Vasut