Re: [PATCH] net: slip: fix out-of-bounds access on short CSLIP packets

[Simon Horman]

On Sun, Sep 20, 2026 at 10:47:30PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 (1) · Low: 2 (1)
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] Commit message describes work that the patch does not do, and
>   names the wrong bug class.
> - [Low] The new reserve literal 120 in sl_bump()
>   (drivers/net/slip/slip.c:338) is undocumented and unlinked to the code…
> - [Low] The Fixes tag is wrong.

The concerns above seem legitimate.

> 
> Pre-existing issues:
> - [Medium] The rx_over_errors early return in sl_bump()
>   (drivers/net/slip/slip.c:338-341) discards a compressed frame without…
> - [Low] Claimed TOCTOU race between the reserve check in sl_bump() and
>   sl_realloc_bufs() swapping/shrinking sl->rbuff and sl->buffsize.

I'm less convinced that the above are in-scope for this patch.

-- 
pw-bot: changes-requested