Re: [PATCH 4/4] ASoC: cdns: Add Cadence I2S-MC controller driver

[Uwe Kleine-König]

Hello Joakim,

On Tue, Sep 22, 2026 at 07:21:34PM +0800, joakim.zhang@xxxxxxxxxxx wrote:
> [...]
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>

Please don't include <linux/mod_devicetable.h>. You can rely on
<linux/platform_device.h> to provide of_device_id instead. (Or if you
prefer it, use <linux/device-id/of.h>

Same for patch #2.

> +#include <linux/pinctrl/consumer.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regmap.h>
> +#include <linux/reset.h>
> +#include <sound/dmaengine_pcm.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc.h>

But please don't rely on <sound/soc.h> pulling in
<linux/platform_device.h>, so please include the latter explicitly.

> [...]
> +static const struct of_device_id cdns_i2s_mc_of_match[] = {
> +	{ .compatible = "cix,sky1-i2s-mc", .data = &sky1_devtype_data},

Missing space before closing }.

> +	{ /* sentinel */ },

Please no comma after the list terminator.

> +};
> +MODULE_DEVICE_TABLE(of, cdns_i2s_mc_of_match);

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature