Re: [PATCH v3 03/33] gpu: nova-core: gsp: give the command queue its own BAR0 mapping

[Alexandre Courbot]

On Fri Sep 18, 2026 at 10:06 AM JST, John Hubbard wrote:
> Sending a command to the GSP ends by writing the GSP doorbell, a BAR0
> register, so every send path through the command queue needs the BAR0
> mapping. A command too large for one queue element goes out as a first
> element followed by continuation records, so the send path has four
> functions.
>
> Nova-core passed the mapping down from the caller as an argument, which
> was threaded through all four functions, and every caller of a send had
> to carry it as well.
>
> Store the mapping in the command queue and drop the argument. The queue
> lives exactly as long as the mapping does, since both belong to the
> bound device.
>
> Suggested-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Assisted-by: LLM
> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>

This patch is merged into `drm-rust-next`, thanks! Less arguments is
always nice to have.