Re: [PATCH 07/12] perf annotate-data: Show the sample count in the data-type browser

From: Arnaldo Carvalho de Melo

Date: Tue Sep 22 2026 - 09:31:03 EST


On Wed, Sep 16, 2026 at 02:28:10PM -0700, Namhyung Kim wrote:
> On Wed, Sep 16, 2026 at 08:47:34AM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> >
> > The data-type browser has a samples view, selected with -n (or with
> > annotate.show_nr_samples), in which browser__write_overhead() prints a
> > local nr_samples variable that is initialized to zero and never
> > updated, so every member is listed as having no samples while the
> > period and percent columns for the same entry are filled in.
> >
> > Print the histogram entry's own count instead.
> >
> > This predates the load/store counter split, so fix it ahead of that
> > patch: the split then only has to adapt a line that is already correct,
> > and this fix can be picked on its own.
> >
> > Fixes: d001c7a7f4736743 ("perf annotate-data: Add hist_entry__annotate_data_tui()")
> > Assisted-by: LLM
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> This can be applied independently.
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>


Thanks, cherry picked into perf-tools-next, for v7.4.

- Arnaldo