Re: (subset) [PATCH] leds: lm3692x: fix regulator/gpio leak and wrong enabled state on last write failure

From: Lee Jones

Date: Tue Sep 22 2026 - 09:17:42 EST


On Tue, 15 Sep 2026 10:45:15 +0700, Cong Nguyen wrote:
> Every write in lm3692x_leds_enable() checks its return and jumps to
> out: on failure -- except the last one, which falls through and sets
> led->enabled = true regardless of whether it actually succeeded. Leaks
> the regulator on a failing probe, and short-circuits later
> brightness_set() calls without retrying.
>
> Route it through out: like every other write here, and only set
> enabled = true once it succeeds.
>
> [...]

Applied, thanks!

[1/1] leds: lm3692x: fix regulator/gpio leak and wrong enabled state on last write failure
commit: 145ca6bca2cc5fd8d9c7af216df58a9c75c0e84c

--
Lee Jones [李琼斯]