Re: [PATCH v2 13/21] modpost: emit module descriptors as assembly

From: Lorenzo Stoakes (ARM)

Date: Tue Sep 22 2026 - 09:10:30 EST


On Mon, Sep 21, 2026 at 12:57:57PM +0100, Lorenzo Stoakes (ARM) wrote:
> On Mon, Sep 21, 2026 at 01:25:09PM +0200, Petr Pavlu wrote:
> > If the <module>.mod.S files are fully self-contained and do not even use
> > something like KBUILD_MODNAME, would it be possible to name them
> > <module>.mod.s and skip the C preprocessor as well?
>
> Ack will do for v4!
>

Unfortunately this broke because the build passes flags that are only
meaningful to the preprocessor (esp. on an LLVM=1 build) and
-Qunused-arguments was removed from kbuild in commit 8d9acfce3332 ("kbuild:
Stop using '-Qunused-arguments' with clang") purposefully.

And some flags are needed and others not so keeping track of which is which
just for this is asking for things to be fragile/break, esp. on the rando
arches.

The win here isn't very much overall so I think I will revert this change
for v4.

(All your other requests have already been applied for v4 :)

--
Cheers, Lorenzo