Re: [PATCH 3/3] media: synopsys: hdmirx: stop logging a missing signal at error level

[Dmitry Osipenko]

On 9/21/26 10:15, Sascha Hauer wrote:
> hdmirx_query_dv_timings() refuses with -ENOLINK while the source is not
> driving the connector's +5V line and with -ENOLCK while the receiver has
> not locked, and prints both at v4l2_err level. Neither is a driver error.
> They are the two states a receiver sits in whenever nothing is plugged
> in, and the way userspace waits for a source is to poll until they clear,
> so an application doing the expected thing fills the kernel log.
> 
> Both states are now reported through VIDIOC_ENUMINPUT as
> V4L2_IN_ST_NO_POWER and V4L2_IN_ST_NO_SIGNAL, from the same two helpers,
> so the prints no longer carry anything userspace cannot ask for. Drop
> them to v4l2_dbg level 1, where the other non-error outcome of this
> function, timings out of range, already is.
> 
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 75576a9366fd0..41f6112ec8123 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -502,12 +502,12 @@ static int hdmirx_query_dv_timings(struct file *file, void *priv,
>  	int ret;
>  
>  	if (port_no_link(hdmirx_dev)) {
> -		v4l2_err(v4l2_dev, "%s: port has no link\n", __func__);
> +		v4l2_dbg(1, debug, v4l2_dev, "%s: port has no link\n", __func__);
>  		return -ENOLINK;
>  	}
>  
>  	if (signal_not_lock(hdmirx_dev)) {
> -		v4l2_err(v4l2_dev, "%s: signal is not locked\n", __func__);
> +		v4l2_dbg(1, debug, v4l2_dev, "%s: signal is not locked\n", __func__);
>  		return -ENOLCK;
>  	}
>  
> 

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>

-- 
Best regards,
Dmitry