Re: [PATCH v2] staging: rtl8723bs: fix ie_length bound check in rtw_cfg80211_inform_bss
From: Dan Carpenter
Date: Tue Sep 22 2026 - 06:32:07 EST
On Mon, Sep 21, 2026 at 04:55:27PM +0000, Adi Prasan wrote:
> The buffer bound check in rtw_cfg80211_inform_bss() only verifies
> that bssinf_len (ie_length + header size) does not exceed
> MAX_BSSINFO_LEN (1000 bytes), but network.ies[] is only MAX_IE_SZ
> (768) bytes. This allows ie_length values up to ~976 bytes to pass
> the check while a subsequent memcpy() from network.ies still reads
> only 768 valid bytes, and other paths that write to network.ies
> consistently cap ie_length to MAX_IE_SZ.
>
> Add an explicit check against MAX_IE_SZ so the bound matches the
> actual size of network.ies.
>
> Signed-off-by: Adi Prasan <itsadi2409@xxxxxxxxx>
> Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver")
Really do some more checking to see if we can use a more sensible
limit instead of MAX_BSSINFO_LEN. Also try figure out where
pnetwork->network.ie_length is set and verify that it can be out
out bounds.
regards,
dan carpenter