Re: [PATCH net v6 1/2] net: validate virtio checksum start after network header

From: Johannes Berg

Date: Tue Sep 22 2026 - 01:58:22 EST


On Tue, 2026-09-22 at 01:14 -0400, Michael S. Tsirkin wrote:
>
> >
> > +/*
> > + * Return the L3 offset and protocol of an Ethernet frame starting at skb->data.
> > + * The offset is unused without NEEDS_CSUM, so avoid parsing and return zero.
> > + */
>
> for networking code multiline comments:
>
> /* always
> * look like this
> */
>
> /*
> * never
> * like this
> */

This, for the record, is't really true any more - we dropped the special
rule a few years ago.

johannes