Re: [PATCH 09/20] crypto: x86/aes-cbc - Remove superseded CBC skciphers

[Eric Biggers]

On Tue, Sep 22, 2026 at 06:15:19AM +0200, Karl Mehltretter wrote:
> On Sun, 20 Sep 2026 22:08:55 -0700 Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> > Now that the AES-CBC (and AES-CBC-CTS) library functions are optimized
> > with dedicated AES-NI code and exposed via the skcipher API via
> > crypto/aes.c, the similar implementation in aesni-intel is redundant.
> > Remove it.
> 
> Hello Eric,
> 
> This breaks the 32-bit build from here until patch 13.
> 
> After this patch the only callers of aesni_skcipher_setkey() are the
> CTR and XTS skciphers, and those are under #ifdef CONFIG_X86_64. On
> i386 the function is left unused, and WERROR is on in i386_defconfig
> and allmodconfig:
> 
>   arch/x86/crypto/aesni-intel_glue.c:104:12: error: 'aesni_skcipher_setkey' defined but not used [-Werror=unused-function]
> 
> Patch 11 does the same to xts_setkey_aesni(). Patch 13 removes both
> helpers, from there on it builds again. I built every commit of the
> series with i386_defconfig plus CRYPTO_AES_NI_INTEL=y, gcc 15.2:

Yes, I'll rearrange things to stop building aesni-intel for 32-bit
before getting to this point.  Thanks!

- Eric