[PATCH] hwrng: omap3-rom: Use pm_runtime_resume_and_get()
From: phucduc . bui
Date: Mon Sep 21 2026 - 23:21:31 EST
From: bui duc phuc <phucduc.bui@xxxxxxxxx>
Replace the open-coded pm_runtime_get_sync() + pm_runtime_put_noidle()
error handling pattern with pm_runtime_resume_and_get(), which already
does this internally.
No functional change.
Found by manual code inspection.
Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
---
drivers/char/hw_random/omap3-rom-rng.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c
index aa71f61c3dc9..0797add0d782 100644
--- a/drivers/char/hw_random/omap3-rom-rng.c
+++ b/drivers/char/hw_random/omap3-rom-rng.c
@@ -42,12 +42,9 @@ static int omap3_rom_rng_read(struct hwrng *rng, void *data, size_t max, bool w)
ddata = (struct omap_rom_rng *)rng->priv;
- r = pm_runtime_get_sync(ddata->dev);
- if (r < 0) {
- pm_runtime_put_noidle(ddata->dev);
-
+ r = pm_runtime_resume_and_get(ddata->dev);
+ if (r < 0)
return r;
- }
ptr = virt_to_phys(data);
r = ddata->rom_rng_call(ptr, 4, RNG_GEN_HW);
--
2.43.0