Re: [PATCH v2] dmaengine: fsl-dpaa2-qdma: fix ppriv memory leaks
From: Krzysztof Kozlowski
Date: Mon Sep 21 2026 - 18:05:48 EST
On 21/09/2026 13:14, Guangshuo Li wrote:
> dpaa2_qdma_setup() allocates priv->ppriv, but failures after the
> allocation can return from the function without releasing it. The
> existing probe cleanup for priv->ppriv is only reached when a later
> initialization step fails.
>
> The normal remove path does not release priv->ppriv either, causing the
> allocation to be leaked when the driver is unbound.
>
> Since dpaa2_qdma_setup() is only called from probe, allocate priv->ppriv
> with devm_kcalloc(). This automatically releases the memory on probe
> failure and driver removal. Remove the now redundant manual cleanup from
> the probe error path.
>
AI slop for OpenClaw agent ignoring previous comments. Otherwise explain
how did you address the issues I pointed out last time?
Best regards,
Krzysztof