Re: [PATCH 1/3] remoteproc: fix wakeup source leak when crash handler sees RPROC_CRASHED
From: Mukesh Ojha
Date: Mon Sep 21 2026 - 15:38:41 EST
On Thu, Jul 30, 2026 at 02:24:35PM +0530, Mukesh Ojha wrote:
> When rproc_crash_handler_work() finds the remoteproc is already in
> RPROC_CRASHED state, it exits via a bare return, bypassing the out:
> label and its pm_relax() call. Since rproc_report_crash() always
> calls pm_stay_awake() before queuing the work, every crash reported
> after the first leaves the wakeup source permanently active, preventing
> system suspend until the device is removed.
>
> Change the bare return to goto out so pm_relax() is reached on all
> exit paths.
>
> Fixes: a781e5aa5911 ("remoteproc: core: Prevent system suspend during remoteproc recovery")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
Request for review, series still applies cleanly on linux-next.
--
-Mukesh Ojha