Re: [PATCH bpf-next v2 01/13] bpf: move linked-scalar flags out of bpf_reg_state->id [NFC]

[Vineet Gupta]

On 9/18/26 4:13 PM, Eduard Zingerman wrote:
> On Mon, 2026-09-14 at 18:17 -0700, Vineet Gupta wrote:
>
> ...
>
> > >    static bool regs_exact(const struct bpf_reg_state *rold,
> > >                   const struct bpf_reg_state *rcur,
> > >                   struct bpf_idmap *idmap)
> > >    {
> > >        return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
> > >               check_ids(rold->id, rcur->id, idmap) &&
> > >               check_ids(rold->parent_id, rcur->parent_id, idmap);
> > >    }
> > > Also even after above change to check_scalar_ids() the check_scalar_ids() is still
> > > no equivalent to check_ids() that regs_exact() is doing.
> > ... Right: reverting back to what we had before.
> > FWIW Eduard had suggested to use regs_exact; I'm not sure if he had
> > something else in mind which we might be overlooking.
> I missed the check_scalar_ids() vs check_ids() difference, sorry.
> Also, yes, let's squash with patch #2.
>
> ...

Yep, will do.

Thx,
-Vineet