Re: [PATCH] PCI: Stop waiting for link status after config read failure

[Yury M.]

On 9/4/26 12:59, Ilpo Järvinen wrote:
> Wouldn't it be better to base such checks on PCI_POSSIBLE_ERROR()?
>
> If you keep the check for the case where pcie_capability_read_word()
> returns error, its return value should be converted with
> pcibios_err_to_errno(), not just return -ENODEV.
1. There is no reason to use PCI_POSSIBLE_ERROR in this case, because 
pcie_capability_read_word() overrides the value returned by 
pci_read_config_word() and sets it to 0 in case of a read failure. So, 
if a read fails, pcie_capability_read_word() returns 0 instead of all Fs.
2. Thanks. I addressed your comment in the v3 patch and used 
pcibios_err_to_errno().

On 9/4/26 12:59, Ilpo Järvinen wrote:
> Kerneldoc wants this formatting:
>
> Return:
3. Addressed this comment as well in the v3 patch.

Thanks