Re: [PATCH 10/28] ASoC: ops: Accept patterns in snd_soc_limit_volume

[Charles Keepax]

On Mon, Sep 21, 2026 at 05:27:33PM +0200, Mark Brown wrote:
> On Sun, Sep 20, 2026 at 02:53:49PM +1000, James Calligeros wrote:
> > From: Martin Povišer <povik+lin@xxxxxxxxxxx>
> > 
> > In snd_soc_limit_volume, instead of looking up a single control by name,
> > also understand wildcard-starting patterns like '* Amp Gain Volume' to
> > touch many controls at one.
> 
> > -	return soc_limit_volume(kctl, max);
> > +	return hits;
> >  }
> >  EXPORT_SYMBOL_GPL(snd_soc_limit_volume);
> 
> This will break the existing Cirrus and TI users which treat non-zero
> values as errors, most users ignore the return value but they check.

Thanks, yeah fixing up the existing users would be greatly
appreciated.

Also are we sure this wildcard approach is the way to go? Does
make me slightly nervous that you could get stuff like a driver
adds a new control and it gets pulled unexpectedly into a
wildcarded limit.

Are you using the wildcard mostly to skip the component prefix
stuff? I wonder if adding an option to match without that might
be more explicit.

Thanks,
Charles