Re: [PATCH v3 2/3] platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver
From: Oleg Keri
Date: Mon Sep 21 2026 - 12:09:15 EST
Hi Ilpo,
On Mon, Sep 21, 2026, Ilpo Järvinen wrote:
> > +Date: August 2026
>
> ??
>
> > +KernelVersion: 7.3
>
> This ship has already sailed.
Will be September 2026 and 7.4.
All the other points will be in v4 as well:
- the missing includes added where the symbols are used
- the cache and stale periods defined in milliseconds, with the unit in
the name, and converted to jiffies at the call
- lockdep_assert_held() in the command path every EC access goes through
- each EC read checked right after the call
- ARRAY_SIZE() for the cell loop
- MILLIDEGREE_PER_DEGREE from units.h instead of the literal
- braces on the multi-line returns
Plus two things not from your review: a shorter i2c id that fits
I2C_NAME_SIZE (the bot's finding), and the symbol prefix renamed to
slim7x_ec to match the driver name, which makes the v4 diff larger
than the changes are.
Thanks,
Oleg