Re: [PATCH] PCI: pciehp: Make poll mode parameter read-only

[Lukas Wunner]

On Mon, Sep 21, 2026 at 10:26:08PM +0800, Runyu Xiao wrote:
> pciehp_request_irq() and pciehp_free_irq() select different resources
> based on the global pciehp_poll_mode parameter. The parameter is
> currently writable through sysfs, so changing it while a controller is
> active can make teardown stop a nonexistent polling thread or call
> free_irq() for an IRQ that was not requested.
> 
> Keep the parameter available for boot and module configuration, but
> prevent runtime changes to the registration mode.
[...]
> Fixes: 2aeeef119995 ("pciehp: Clean up pcie_init()")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: LLM Codex
> Signed-off-by: Runyu Xiao <runyu.xiao@xxxxxxxxxx>

Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>

The Fixes tag looks odd to me because the module_param has existed
before the tree was even converted to git, as has the irq usage.
I'd just drop the Fixes tag and use only the stable designation.

Thanks,

Lukas