Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats

[Pankaj Patil]

On 9/18/2026 2:04 PM, Konrad Dybcio wrote:
> On 9/15/26 6:09 AM, Navya Malempati wrote:
>>
>>
>> On 9/8/2026 3:33 PM, Pankaj Patil wrote:
>>> On 9/8/2026 1:43 PM, Navya Malempati wrote:
>>>> Add SMEM items for four NSP subsystems stats which are present in Nord
>>>> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
>>>> id. Add new entries for NSP1/2/3.
>>>
>>> For other targets as well is the same applicable? NSP and CDSP are interchangeable?
>>>
>> From the stats point of view, they are the same, we used the name NSP in downstream, it looks like Nord SoC remoteproc is using the name CDSP [1]
>>
>> [1] https://lore.kernel.org/linux-arm-msm/20260904081619.593602-2-shengchao.guo@xxxxxxxxxxxxxxxx/
>>

Downstream conventions can't be added upstream, if upstream dt entries
are not named the same way. Please revert this

>>>>
>>>> Signed-off-by: Navya Malempati <navya.malempati@xxxxxxxxxxxxxxxx>
>>>> ---
>>>>   drivers/soc/qcom/qcom_stats.c | 5 ++++-
>>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
>>>> index 06923408bfce..91f2d1293124 100644
>>>> --- a/drivers/soc/qcom/qcom_stats.c
>>>> +++ b/drivers/soc/qcom/qcom_stats.c
>>>> @@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
>>>>       { "modem", 605, 1 },
>>>>       { "wpss", 605, 13 },
>>>>       { "adsp", 606, 2 },
>>>> -    { "cdsp", 607, 5 },
>>>> +    { "cdsp_nsp", 607, 5 },
>>>>       { "cdsp1", 607, 12 },
>>>
>>> Is cdsp1 not the same as nsp1?
>>
>> No, cdsp1 is not the same as nsp1.

Please explain if the dt entries are named as remoteproc_cdspx then what
does cdsp_nspx correspond to? Subsystems are common across all soc's

> 
> It would make sense to explain the difference here!
> 
> Konrad