Re: [PATCH] mctp: route: verify socket ownership in mctp_lookup_prealloc_tag()

[krzk]

On Sat, 19 Sep 2026 21:28:51 +0000, Hui Peng wrote:
> When a socket transmits a packet with `MCTP_TAG_PREALLOC` set,
> mctp_lookup_prealloc_tag() iterates over the per-netns `&mns->keys` list
> and matches `netid`, `req_tag`, `peer_addr`, and `manual_alloc`, but
> omits checking whether `tmp->sk == &msk->sk`.
> 
> Because all preallocated tags (`0..7`) reside in the shared per-netns
> `&mns->keys` list, any local `AF_MCTP` socket can specify another
> socket's preallocated tag and cause incoming replies to be matched
> against the victim socket's `mctp_sk_key` or reset its expiry state.
> 
> Verify `tmp->sk == &msk->sk` in `mctp_lookup_prealloc_tag()`.
> 
> Fixes: 63ed1aab3d40 ("mctp: Add SIOCMCTP{ALLOC,DROP}TAG ioctls for tag control")
> Assisted-by: LLM
> Signed-off-by: Hui Peng <benquike@xxxxxxxxx>
> 
> ---
>  net/mctp/route.c | 3 +++
>  1 file changed, 3 insertions(+)
> 


You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem, how to document usage of LLM and how what you should not
do if this was posted in a good faith.

Best regards,
Krzysztof