Re: [PATCH v2 2/5] dt-bindings: PCI: qcom,shikra-pcie: Document the Shikra PCIe Controller

[Krzysztof Kozlowski]

On 21/09/2026 15:47, Sushrut Shree Trivedi wrote:
> 
> On 9/1/2026 2:12 PM, Krzysztof Kozlowski wrote:
>> On Mon, Aug 31, 2026 at 12:56:02PM +0530, Sushrut Shree Trivedi wrote:
>>> Add a dedicated schema for the PCIe controller found on the Shikra
>>> platform.
>>>
>>> Shikra controller supports upto PCIe Gen3 but the PHY is
>>> only capable of Gen2, hence the max link speed  is limited
>>> to Gen2 to avoid link-up failures.
>>>
>>> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@xxxxxxxxxxxxxxxx>
>>> ---
>>>   .../devicetree/bindings/pci/qcom,shikra-pcie.yaml  | 218 +++++++++++++++++++++
>>>   1 file changed, 218 insertions(+)
>>>
>> What is the difference in the binding against Eliza? IOW, why does this
>> need a separate file unlike Eliza?
> Shikra does not have the Config NoC AXI clock unlike sm8550 / eliza. Apart
> from that, minItems for reg  and interrupts need to be updated. I actually

Really? Did you even check? I looked at Eliza and it has 6 minItems for
reg. Your patch defines how many exactly?

I did not check the rest of the arguments because it is not a game "I
will say whatever and maintainer will need to verify each of my claims".
I find one false claim and that drops this from Patchwork.

Best regards,
Krzysztof