Re: [PATCH] remoteproc: qcom_q6v5_mss: Fix missing PDM subdev cleanup on probe failure

[Konrad Dybcio]

On 9/16/26 9:56 AM, Anup Vishwakarma wrote:
> q6v5_probe() calls qcom_add_pdm_subdev() but the remove_subdevs:
> error unwind never calls qcom_remove_pdm_subdev(). If
> qcom_add_sysmon_subdev() or rproc_add() subsequently fails, the PDM
> subdev remains registered in the rproc subdev list.
> 
> The three sibling drivers (qcom_q6v5_adsp.c, qcom_q6v5_pas.c,
> qcom_q6v5_wcss.c) all correctly call qcom_remove_pdm_subdev() in
> their probe error unwind. Add the missing call after
> qcom_remove_ssr_subdev(), in reverse order of registration.
> 
> Fixes: 5b9f51b200dc ("remoteproc: qcom: enable in-kernel PD mapper")
> Signed-off-by: Anup Vishwakarma <anup.vishwakarma@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad