Re: [PATCH] modules/kmod: Allocate argv with kmalloc_array()

[Petr Pavlu]

On 9/17/26 11:12 PM, Kees Cook wrote:
> From: Kees Cook <kees+treewide@xxxxxxxxxx>
> 
> In preparation for converting the kmalloc family of allocators to the
> type-aware kmalloc_obj family, we need to make sure that the returned
> type from the allocation matches the type of the variable being
> assigned. (The kmalloc family returns "void *", which can be implicitly
> cast to any pointer type.)
> 
> argv holds 5 pointers, but the size was taken from the array type
> "char *[5]", which would make the allocation type a pointer to that
> array rather than the "char **" being assigned. Allocate 5 entries of
> the target's type instead. The resulting allocation size is the same.
> 
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> kernel/module/kmod.o
> 
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@xxxxxxxxxx>

Looks ok to me. I've queued the patch on modules-next for 7.4-rc1.

-- 
Thanks,
Petr