[PATCH] vdso/gettimeofday: Avoid runtime conditional in do_hres_timens()
From: Thomas Weißschuh
Date: Mon Sep 21 2026 - 06:07:19 EST
Currently the derivation of the non-namespaced clock from its namespaced
sibling uses a runtime conditional. This conditional mirrors the
VDSO_RAW check in __cvdso_clock_gettime_common(), in a non-obvious way.
Replace the runtime conditional with unconditional pointer arithmetic,
which removes the duplication of logic and also is smaller and faster.
Also get rid of the weird double use of the 'vc' variable, pointing both
to the array of clocks and later to one specific one.
This saves 31 bytes of .text on x86_64.
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
lib/vdso/gettimeofday.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c
index f7a591aba59f..7c45a8be9185 100644
--- a/lib/vdso/gettimeofday.c
+++ b/lib/vdso/gettimeofday.c
@@ -135,22 +135,23 @@ const struct vdso_time_data *vdso_timens_data(const struct vdso_time_data *vd)
return (void *)vd + PAGE_SIZE;
}
+static __always_inline
+const struct vdso_clock *vdso_timens_clock(const struct vdso_clock *vc)
+{
+ return (void *)vc + PAGE_SIZE;
+}
+
static __always_inline
bool do_hres_timens(const struct vdso_time_data *vdns, const struct vdso_clock *vcns,
clockid_t clk, struct __kernel_timespec *ts)
{
const struct vdso_time_data *vd = vdso_timens_data(vdns);
+ const struct vdso_clock *vc = vdso_timens_clock(vcns);
const struct timens_offset *offs = &vcns->offset[clk];
- const struct vdso_clock *vc = vd->clock_data;
u32 seq;
s64 sec;
u64 ns;
- if (clk != CLOCK_MONOTONIC_RAW)
- vc = &vc[CS_HRES_COARSE];
- else
- vc = &vc[CS_RAW];
-
do {
seq = vdso_read_begin(vc);
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260917-vdso-timens-conditional-56d17351cd31
Best regards,
--
Thomas Weißschuh <linux@xxxxxxxxxxxxxx>