Re: [PATCH v5 06/17] f2fs: stop using PG_private
From: Lance Yang
Date: Mon Sep 21 2026 - 03:28:05 EST
On 2026/9/21 10:28, Zi Yan wrote:
f2fs sets its PAGE_PRIVATE_* flags in page->private and checking
page->private != NULL is equivalent to checking PG_private. Change
PagePrivate() to page_private(). Meanwhile, in set_page_private_##name(),
page->private is first set to 0/NULL before an PAGE_PRIVATE_* flag is set,
but it can cause confusion when PG_private is removed and
page->private != NULL is used instead. Change it to initialize
page->private to PAGE_PRIVATE_NOT_POINTER instead and retain the original
semantics.
It prepares for a future commit that removes PG_private.
No functional change intended.
Assisted-by: LLM
To: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
To: Chao Yu <chao@xxxxxxxxxx>
Cc: linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Acked-by: Usama Arif <usama.arif@xxxxxxxxx>
Acked-by: Chao Yu <chao@xxxxxxxxxx>
Reviewed-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
---
LGTM. Feel free to add:
Reviewed-by: Lance Yang <lance.yang@xxxxxxxxx>