Re: [PATCH] ALSA: hda/realtek: Match Yoga Pro 9 16IAH10 quirk by codec SSID

[Zhang Heng]

Thanks for the patch.
I agree this needs to be fixed, since it affects other sound cards.

I think it might be cleaner to reuse the existing quirk and drop the 
separate entry, something like this:

--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8214,7 +8214,6 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x17aa, 0x3834, "Lenovo IdeaPad Slim 9i 14ITL5", 
ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
        SND_PCI_QUIRK(0x17aa, 0x383d, "Legion Y9000X 2019", 
ALC285_FIXUP_LEGION_Y9000X_SPEAKERS),
        SND_PCI_QUIRK(0x17aa, 0x3843, "Lenovo Yoga 9i / Yoga Book 9i", 
ALC287_FIXUP_LENOVO_YOGA_BOOK_9I),
-       SND_PCI_QUIRK(0x17aa, 0x3846, "Lenovo Yoga Pro 9 16IAH10", 
ALC287_FIXUP_YOGA9_SPEAKER2_TO_DAC1),
        /* Yoga Pro 7 14IMH9 shares PCI SSID 17aa:3847 with Legion 7 
16ACHG6;
         * use codec SSID to distinguish them
         */
@@ -8308,7 +8307,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x17aa, 0x3912, "Lenovo Xiaoxin 14 GT", 
ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
        SND_PCI_QUIRK(0x17aa, 0x3913, "Lenovo 145", 
ALC236_FIXUP_LENOVO_INV_DMIC),
        SND_PCI_QUIRK(0x17aa, 0x391f, "Yoga S990-16 pro Quad YC Quad", 
ALC287_FIXUP_TXNW2781_I2C),
-       SND_PCI_QUIRK(0x17aa, 0x3920, "Yoga S990-16 pro Quad VECO Quad", 
ALC287_FIXUP_TXNW2781_I2C),
+       SND_PCI_QUIRK(0x17aa, 0x3920, "Yoga S990-16 pro Quad VECO Quad", 
ALC287_FIXUP_YOGA9_SPEAKER2_TO_DAC1),
        SND_PCI_QUIRK(0x17aa, 0x3929, "Thinkbook 13x Gen 5", 
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
        SND_PCI_QUIRK(0x17aa, 0x392b, "Thinkbook 13x Gen 5", 
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
        HDA_CODEC_QUIRK(0x17aa, 0x3936, "Legion R9000P ADR10H", 
ALC287_FIXUP_LENOVO_LEGION_AW88399),

Since both entries use the same external amplifier,
reusing the existing quirk seems more consistent.

Does that look reasonable to you?