Re: [PATCH v1] HID: sensor-hub: synchronize multi-value read cancellation

[Jonathan Cameron]

On Thu, 17 Sep 2026 01:16:09 +0000
"Zhang, Lixu" <lixu.zhang@xxxxxxxxx> wrote:

> >-----Original Message-----
> >From: Zhang, Lixu
> >Sent: Friday, September 11, 2026 1:17 PM
> >To: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>; Yibo Tan
> ><lhfff@xxxxxxxxxx>; Jiri Kosina <jikos@xxxxxxxxxx>; Jonathan Cameron
> ><jic23@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>
> >Cc: Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>; linux-
> >input@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> >Subject: RE: [PATCH v1] HID: sensor-hub: synchronize multi-value read
> >cancellation
> >  
> >>-----Original Message-----
> >>From: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> >>Sent: Friday, September 11, 2026 2:29 AM
> >>To: Yibo Tan <lhfff@xxxxxxxxxx>; Jiri Kosina <jikos@xxxxxxxxxx>;
> >>Jonathan Cameron <jic23@xxxxxxxxxx>; Benjamin Tissoires
> >><bentiss@xxxxxxxxxx>
> >>Cc: Zhang, Lixu <lixu.zhang@xxxxxxxxx>; Shevchenko, Andriy
> >><andriy.shevchenko@xxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-
> >>iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> >>Subject: Re: [PATCH v1] HID: sensor-hub: synchronize multi-value read
> >>cancellation
> >>
> >>On Thu, 2026-09-10 at 19:23 +0800, Yibo Tan wrote:  
> >>> sensor_hub_input_attr_read_values() publishes a caller-owned buffer
> >>> to the raw-event path. If its interruptible wait times out or is
> >>> interrupted, it clears pending.status without taking data->lock and
> >>> returns.
> >>>  
> >>
> >>Hi Lixu,
> >>
> >>Please give me quick test. Change itself looks good, not sure if we
> >>need something more.  
> >Hi Srinivas,
> >
> >The machine is currently running other tests. Once they are done next week, I
> >will run a quick test on this change and get back to you with feedback.  
> 
> Tested-by: Zhang Lixu <lixu.zhang@xxxxxxxxx>
> 
> I did some basic validation on a real HID sensor hub / rotation sensor system and did not see a regression from this patch.
> 
Great. Thanks!

Yibo Tan, please can you spin a v2 addressing the other feedback.

thanks,

Jonathan

> Thanks,
> Lixu
> 
> >
> >Thanks,
> >Lixu
> >  
> >>
> >>Thanks,
> >>Srinivas  
> >  
>