Re: [PATCH v1 1/1] iio: adc: ad7173: Fix digital filter configuration

[Jonathan Cameron]

On Wed, 16 Sep 2026 14:01:34 -0300
Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:

> Filter enable and filter type selection masks were swapped on data
> preparation for filter configuration register write. Use the correct masks
> to set each property of post filter configuration.
> 
> Fixes: bb688cd9f772 ("iio: adc: ad7173: support changing filter type")
That's not a valid hash.  Fixed up whilst applying.

Applied to the fixes-togreg branch of iio.git.


> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> ---
>  drivers/iio/adc/ad7173.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index eb47175a0528..faebb7b34a15 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -775,9 +775,9 @@ static int ad7173_load_config(struct ad7173_state *st,
>  
>  	return ad_sd_write_reg(&st->sd, AD7173_REG_FILTER(free_cfg_slot), 2,
>  			       FIELD_PREP(AD7173_FILTER_SINC3_MAP, 0) |
> -			       FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
> -					  post_filter_enable) |
>  			       FIELD_PREP(AD7173_FILTER_ENHFILTEN,
> +					  post_filter_enable) |
> +			       FIELD_PREP(AD7173_FILTER_ENHFILT_MASK,
>  					  post_filter_select) |
>  			       FIELD_PREP(AD7173_FILTER_ORDER, 0) |
>  			       FIELD_PREP(AD7173_FILTER_ODR_MASK,
> 
> base-commit: 9c464e7473f762cee4c031a09da04f65a1c65d49