Re: [PATCH v4 3/5] iio: imu: inv_icm42607: Add support for ICM-42370-P

[Jonathan Cameron]

On Thu, 17 Sep 2026 15:38:18 +0200
Kanak Shilledar <kanak.shilledar@xxxxxxxx> wrote:

> Add support for the Invensense ICM-42370-P MEMS MotionTracking 3-axis
> accelerometer with built-in temperature sensor. This device is almost
> identical to the existing Invensense ICM-42607-P IMU, but lacks
> gyroscope. The device supports I2C, SPI and I3C, implement only I2C
> support. Provide basic support for raw sensor reads via sysfs. There is
> also a built-in temperature sensor but it can not be turned off similar
> to the ICM-42607. Return with `dev_err_probe()` when WHO_AM_I read
> fails.

In ideal world, the has_gyro bit would be split off into a no-op precursor
patch where it is set for all existing supported devices.  This
patch would then just bring the new device support.  Not something
I'd block a series on but I think you are doing a v5 anyway so a
definite nice to have change for that.

Otherwise looks good to me.

Jonathan
> 
> Datasheet: https://www.invensense.tdk.com/en-us/products/3-axis/icm-42370-p
> Datasheet: https://www.lcsc.com/product-detail/C5129967.html
So this is the 42607.  Not sure we need that Datasheet tag here
as you are just referring to it as 'similar'.

> Signed-off-by: Kanak Shilledar <kanak.shilledar@xxxxxxxx>