Re: [PATCH v2 0/6] iio: adc: ade9000: add ADE9430 support

[Jonathan Cameron]

On Fri, 18 Sep 2026 16:27:30 +0100
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Fri, 2026-09-18 at 10:35 +0300, Antoniu Miclaus wrote:
> > The ADE9430 is a polyphase energy metering device from the same family as
> > the ADE9000. It is register-compatible with the ADE9000 but omits the
> > on-chip dip/swell detection and has no on-chip digital integrator; it
> > relies on an external analog integrator for Rogowski coil current sensors.
> > 
> > This series adds ADE9430 support to the existing ade9000 driver, reusing
> > the dip/swell-less channel table introduced for the ADE9078 and adding a
> > matching chip_info for the ADE9430 full-scale codes. A precursor patch
> > gates the DICOEFF register write behind a has_digital_integrator chip_info
> > flag so it is skipped on parts without an on-chip digital integrator.
> > 
> > Patches 1 and 2 are standalone fixes carried with this series. Patch 1
> > corrects the ADE9000 full-scale RMS/PCF codes to the same family-A values
> > the ADE9430 uses. Patch 2 fixes the DIPC event never being handled or
> > cleared, found by the sashiko review of v1. Both carry Fixes: tags and can
> > be applied independently of the rest of the series.
> > 
> > Changes in v2:
> > - new patch: fix the DIPC event never being handled or cleared, found by
> >   the sashiko review of v1 (patch 2).
> > - new precursor patch: gate the DICOEFF write behind a has_digital_integrator
> >   chip_info flag, split out of the ADE9430 support patch.
> > - reuse ade9078_channels for the ADE9430 instead of adding a duplicate
> >   channel table.
> > - reword the documentation intro to "The supported parts are..." so it does
> >   not need updating for each new part.
> > 
> > v1:
> > https://lore.kernel.org/linux-iio/20260907101623.8730-1-antoniu.miclaus@xxxxxxxxxx/
> > 
> > Antoniu Miclaus (6):
> >   iio: adc: ade9000: fix ADE9000 full-scale RMS and PCF codes
> >   iio: adc: ade9000: fix DIPC event never being handled or cleared
> >   dt-bindings: iio: adc: adi,ade9000: add adi,ade9430 compatible
> >   iio: adc: ade9000: gate the DICOEFF write behind a chip_info flag
> >   iio: adc: ade9000: add support for ADE9430
> >   docs: iio: ade9000: document ADE9430 support
> > 
> >  .../bindings/iio/adc/adi,ade9000.yaml         | 22 ++++++-----
> >  Documentation/iio/ade9000.rst                 | 36 +++++++++--------
> >  drivers/iio/adc/Kconfig                       |  1 +
> >  drivers/iio/adc/ade9000.c                     | 39 ++++++++++++++++---
> >  4 files changed, 67 insertions(+), 31 deletions(-)
> > 
> > 
> > base-commit: edb91bc566576f6664a3efbad6bd4205aa1d5259  
> 
> LGTM
> 
> Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
LGTM2.  Just need to give some time for dt-binding reviewers to
take a look.

Thanks,

J