Re: [PATCH] pinctrl: fix PINCTRL_SPPCTL=m

[Linus Walleij]

On Wed, Sep 16, 2026 at 12:49 PM Andrew Gaylard <ag@xxxxxxxxxxxx> wrote:

> The PINCTRL_SPPCTL option is defined as a tristate in Kconfig, and the
> help text suggests that the user can build it as a module by setting to
> 'm'.
>
> However, it cannot currently be set to 'm', because SOC_SP7021, the only
> platform that supports it, is a bool option that uses 'select' on it.
> Also, the SP7021 requires this driver to be built in, in order to boot.
>
> Change the tristate to bool and fix the help text.
>
> Tested on linux-next-2026-09-14 on a LTPP3G2 board.
>
> This impossible tristate was detected by kconfirm, a static analysis tool
> for Kconfig, by Julian Braha <julianbraha@xxxxxxxxx>.
>
> Fixes: aa74c44be19c ("pinctrl: Add driver for Sunplus SP7021")
> Signed-off-by: Andrew Gaylard <ag@xxxxxxxxxxxx>

I applied this patch as a nonurgent fix.

Yours,
Linus Walleij