R: [PATCH 2/3] dt-bindings: arm: marvell: Add Sophos XGS 107w NPU

[Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it]

Hi Krzysztof,

Thanks for the review.

> Looks like you add to the end of the file, not in correct spot.

In v2 the entry is next to the other CN9130 board entries, before the SolidRun ones, instead of at the end of the list.

> Why is cn9130 used once as final compatible and once as not?

I understood this as the difference between my entry (marvell,cn9130 followed by the AP807 compatibles) and the SolidRun CN9130 boards above it (marvell,cn9130 last). In v2 the entry and the device tree both use "sophos,xgs107w-npu", "marvell,cn9130", like the SolidRun boards, so cn9130 is always the last compatible. If you meant something else, please tell me before I send v2.

I will send v2 as a new thread after the 24 hours have passed, with your Acked-by on patch 1.

Thanks,
Nicolo Giuliani

________________________________________
Da: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Inviato: domenica 20 settembre 2026 20:27
A: Nicolò Giuliani - nicolo.giuliani6@xxxxxxxxxxxxxxx
Cc: Rob Herring; Krzysztof Kozlowski; Conor Dooley; Andrew Lunn; Gregory Clement; Sebastian Hesselbarth; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Oggetto: Re: [PATCH 2/3] dt-bindings: arm: marvell: Add Sophos XGS 107w NPU

On Sat, Sep 19, 2026 at 09:44:18PM +0200, Nicolo Giuliani wrote:
> The Sophos XGS 87/107 desktop firewalls combine an AMD x86 host with a
> separate network processing unit (NPU). The NPU is a Marvell Armada CN9130
> SoC with its own eMMC and SPI NOR flash, connected to the x86 host over
> PCIe. It serves the front panel ports through a Marvell 88E6193X switch.
>
> Document the compatible string of the NPU board, with the CN9130 SoC
> compatibles as fallbacks.
>
> Assisted-by: LLM
> Signed-off-by: Nicolo Giuliani <nicolo.giuliani6@xxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 7e77310da6..2e114139f1 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -136,4 +136,13 @@ properties:
>            - const: solidrun,cn9132-sr-cex7
>            - const: marvell,cn9130
>

Looks like you add to the end of the file, not in correct spot.

> +      - description:
> +          Sophos XGS 87/107 network processing unit (Armada CN9130 SoC
> +          with an 88E6193X switch)
> +        items:
> +          - const: sophos,xgs107w-npu
> +          - const: marvell,cn9130

Why is cn9130 used once as final compatible and once as not?

> +          - const: marvell,armada-ap807-quad
> +          - const: marvell,armada-ap807

Best regards,
Krzysztof