Re: [PATCH] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
From: Suryansh Singh
Date: Sun Sep 20 2026 - 02:38:21 EST
On Sat, Sep 19, 2026 at 09:24:25 +0800, Shuwen Bao wrote:
> Add 8F1C to the OMEN thermal profile board list. On this platform
> the EC firmware also arms its own thermal profile revert timer (EC
> offset 0x63, armed with 0x5a when performance is selected) and
> switches back to the balanced profile once it expires, so also add
> the board to omen_timed_thermal_profile_boards in order to have the
> driver clear the timer and set the NOTIMER|TURBO flags when
> switching to the performance profile. Testing further showed that
> this board uses v0 commands, so also add it to
> omen_thermal_profile_force_v0_boards.
Thanks for the patch.
It is slightly unusual to see a board ID ending up in all 3 arrays.
(I believe no other board is present in the base, force v0 and
timed thermal profile simultaneously.)
But, it has been explained well in the commit message and tested,
so it is completely plausible.
Oh, and since the first revision of this patch had a corrupted
patch file (stated by the maintainer), I did apply it to check,
and it works.
LGTM.
Reviewed-by: Suryansh Singh <technosfan14@xxxxxxxxx>