Re: [PATCH v3 0/5] MIPS: GIC clocksource/irqchip improvements and fixes for multi-cluster systems

[Thomas Gleixner]

On Mon, Sep 07 2026 at 14:46, Benoît Monin wrote:

Can the MIPS people who care about this code spend some time on
reviewing this pile?

  https://lore.kernel.org/871pb9841j.ffs@fw13

> This series addresses multi-cluster MIPS GIC handling: it fixes a few
> cross-cluster and lock bugs, and allows the GIC timer to be used as a
> fast local clocksource on multi-cluster systems by synchronizing the
> per-cluster counters.
>
> If you are wondering how a single patch in version one turned into a
> five-patch series in version two, the answser is PROVE_LOCKING which
> found some issues that this series addresses.
>
> The first three patches are for the irq-mips-gic irqchip driver.
>
> The first patch fixes the for_each_online_cpu_gic() macro which
> was releasing an unheld per-CPU cm_core_lock on every invocation
> on multi-cluster hardware. Move both the acquire and release into
> __gic_with_next_online_cpu() so they stay balanced and the for_each
> macro accesses all VP on a multi-cluster system.
>
> The second patch fixes a recursive acquisition of gic_lock in
> gic_set_affinity() when moving interrupt SMP affinity across clusters,
> caused by a call to gic_set_type(). Split out a gic_set_type_locked()
> helper to resolve the issue.
>
> The third patch enables the interrupt when moving affinity across
> clusters. The interrupt mask is per-cluster, so after a cross-cluster
> affinity change the interrupt was left disabled in the destination
> cluster. Handle the mask explicitly on both the old and the new side.
>
> The last two patches are for the mips-gic-timer clocksource driver.
>
> The fourth patch is what changed from version 2 of the series. It
> simplifies gic_next_event() as it is guaranteed to be invoked on the
> same CPU of the event. And the flag CLOCK_EVT_FEAT_PERCPU is added to
> better document that guarantee.
>
> The last patch is the main functional change, carried over from v1. It
> synchronizes each secondary cluster's GIC counter to cluster 0's counter
> as its CPUs come online, and once every cluster is in sync, promote the
> clocksource back from the slow cross-cluster gic_hpt_read_multicluster()
> path to the fast local gic_hpt_read(), also re-enabling the GIC
> VDSO clock mode. On the dual-cluster Mobileye EyeQ6H SoC this makes
> clock_gettime(CLOCK_MONOTONIC) about four times faster on the secondary
> cluster and replaces the jiffies-based sched_clock with the high-precision
> GIC counter.
>
> This series was tested on Mobileye SoCs with different cluster
> configurations:
> * The EyeQ5 with two clusters but only one is equipped with VP
>   (VP topology {2,2,2,2},{} total 8).
> * The EyeQ6Lplus which is strictly single cluster
>   (VP topology {4,4} total 8).
> * The EyeQ6H with two identical clusters
>   (VP topology {4,4,4,4},{4,4,4,4} total 32).
>
> Although I am posting this as a single series since the patches
> are all related to the GIC, the changes to the irqchip driver and
> to the clocksource driver are independent from each other and can be
> merged in different trees. I can split the series in two if it helps
> reviewing/merging.
>
> Signed-off-by: Benoît Monin <benoit.monin@xxxxxxxxxxx>
> ---
> Changes in v3:
> - Rebased on v7.3-rc1.
> - Simplified gic_next_event() as it is strictly per-CPU instead of fixing
>   unused code.
> - Link to v2: https://patch.msgid.link/20260810-sync-gic-counters-v2-0-dfe8b2c376b0@xxxxxxxxxxx
>
> Changes in v2:
> - Four new patches described above fixing multi-cluster
>   handling in the GIC irqchip and clocksource drivers.
> - In the last patch, gic_clocksource_promote() is now deferred via a
>   workqueue instead of a CPUHP ONLINE callback, to avoid a lockdep
>   issue on clocksource_mutex.
> - Link to v1: https://patch.msgid.link/20260724-sync-gic-counters-v1-1-aa24fd0f30bf@xxxxxxxxxxx
>
> To: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> To: Thomas Gleixner <tglx@xxxxxxxxxx>
> To: Dragan Mladjenovic <dragan.mladjenovic@xxxxxxxxxx>
> To: Chao-ying Fu <cfu@xxxxxxxxxxxx>
> To: Aleksandar Rikalo <arikalo@xxxxxxxxx>
> To: Paul Burton <paulburton@xxxxxxxxxx>
> To: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> To: Radu Rendec <radu@xxxxxxxxxx>
> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
>
> ---
> Benoît Monin (5):
>       irqchip/mips-gic: Fix unbalanced cm_core_lock in for_each_online_cpu_gic()
>       irqchip/mips-gic: Fix recursive acquisition of gic_lock in gic_set_affinity()
>       irqchip/mips-gic: Enable interrupt when moving affinity across clusters
>       clocksource: mips-gic-timer: Simplify gic_next_event() for per-cpu timer
>       clocksource: mips-gic-timer: Use local counter on synced multi-cluster systems
>
>  drivers/clocksource/mips-gic-timer.c | 127 +++++++++++++++++++++++++++++++----
>  drivers/irqchip/irq-mips-gic.c       |  51 ++++++++------
>  2 files changed, 144 insertions(+), 34 deletions(-)
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260717-sync-gic-counters-1cd6b40b968e
>
> Best regards,
> --  
> Benoît Monin, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com