Re: [PATCH] staging: media: atomisp: remove ia_css_circbuf_t typedef

From: Dan Carpenter

Date: Sat Sep 19 2026 - 06:40:47 EST


On Fri, Sep 18, 2026 at 09:41:32PM +0000, Rareș-Mihai Vladu wrote:
> @@ -320,24 +319,24 @@ static inline uint32_t ia_css_circbuf_get_free_elems(
> * @brief Peek an element in Circular Buffer.
> *
> * @param cb The pointer to the circular buffer.
> - * @param offset Offset to the element.
> + * @param offset to the element.

Don't make unrelated changes like this. Also it's not really
correct. It's trying to describe "offset" using a sentence.
"Offset to the element." is a sentence but "to the element."
is not a sentence.

> *
> * @return the elements value.
> */
> uint32_t ia_css_circbuf_peek(
> - ia_css_circbuf_t *cb,
> + struct ia_css_circbuf_s *cb,
> int offset);
>
> /*
> * @brief Get an element in Circular Buffer.
> *
> * @param cb The pointer to the circular buffer.
> - * @param offset Offset to the element.
> + * @param offset to the element.
> *

Same.

regards,
dan carpenter