Re: [PATCH] staging: iio: adc: ad7816: Protect sysfs attributes with mutex

From: Joshua Crofts

Date: Sat Sep 19 2026 - 05:31:33 EST


On Sat, 19 Sep 2026 11:55:13 +0300
Abdelnasser Hussein <abdelnasserhussein11@xxxxxxxxx> wrote:

...

> @@ -143,6 +143,7 @@ static ssize_t ad7816_store_mode(struct device *dev,
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ad7816_chip_info *chip = iio_priv(indio_dev);
>
> + guard(mutex)(&chip->lock);

+ Blank line.

> if (strcmp(buf, "full") == 0) {
> gpiod_set_value(chip->rdwr_pin, 1);
> chip->mode = AD7816_FULL;
> @@ -207,6 +208,7 @@ static ssize_t ad7816_store_channel(struct device *dev,
> return -EINVAL;
> }
>
> + guard(mutex)(&chip->lock);

+ Blank line.

> chip->channel_id = data;

With these issues addressed,

Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

--
Kind regards,
Joshua Crofts