Re: [PATCH] nvmem: layouts: onie-tlv: Fix np reference leak in onie_tlv_add_cells()

[Srinivas Kandagatla]

On 9/17/26 1:35 PM, Wentao Liang wrote:
> of_get_child_by_name() returns a node with an elevated reference count.
> nvmem_add_one_cell() only takes ownership of that reference on success,
> so the caller must drop it when the call fails. Add the missing
> of_node_put() before returning so that cell.np is not leaked.
> 

Same comment, do not waste time with duplicate patches.

--srini

> Fixes: d3c0d12f6474 ("nvmem: layouts: onie-tlv: Add new layout driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> ---
>  drivers/nvmem/layouts/onie-tlv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/layouts/onie-tlv.c b/drivers/nvmem/layouts/onie-tlv.c
> index 0967a32319a2..3d77680f089b 100644
> --- a/drivers/nvmem/layouts/onie-tlv.c
> +++ b/drivers/nvmem/layouts/onie-tlv.c
> @@ -128,6 +128,7 @@ static int onie_tlv_add_cells(struct device *dev, struct nvmem_device *nvmem,
>  
>  		ret = nvmem_add_one_cell(nvmem, &cell);
>  		if (ret) {
> +			of_node_put(cell.np);
>  			of_node_put(layout);
>  			return ret;
>  		}