Re: [PATCH 3/4] arm64: dts: allwinner: sun55i-a523: add I2C0 and I2C1 pin groups

[Andre Przywara]

Hi,

On 9/18/26 18:54, Mikhail Kalashnikov wrote:
> Add the pin groups for the I2C0 (PH0/PH1) and I2C1 (PH2/PH3) controllers
> that used on some A523 boards.

I was about to say we should add port specifiers to the node names and 
labels (i2c0-ph-pins), for functions which are also available on other 
pins, but I see we don't do this for I2C on any other SoC, so that's 
fine. It's internal, so we can fix this later.

Compared against the manual:
> Assisted-by: OpenCode:DeepSeek-V4.1-Flash
> Signed-off-by: Mikhail Kalashnikov <iuncuim@xxxxxxxxx>

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Thanks,
Andre

> ---
>   arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 85ef492ff..0ec5d19f7 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -147,6 +147,24 @@ pio: pinctrl@2000000 {
>   			interrupt-controller;
>   			#interrupt-cells = <3>;
>   
> +			/omit-if-no-ref/
> +			i2c0_pins: i2c0-pins {
> +				pins = "PH0", "PH1";
> +				function = "i2c0";
> +				allwinner,pinmux = <2>;
> +				drive-strength = <10>;
> +				bias-pull-up;
> +			};
> +
> +			/omit-if-no-ref/
> +			i2c1_pins: i2c1-pins {
> +				pins = "PH2", "PH3";
> +				function = "i2c1";
> +				allwinner,pinmux = <2>;
> +				drive-strength = <10>;
> +				bias-pull-up;
> +			};
> +
>   			/omit-if-no-ref/
>   			i2s2_pi_pins: i2s2-pi-pins {
>   				pins = "PI2", "PI3", "PI4", "PI5";