Re: [PATCH net-next] net: phy: mediatek: do not match MT7530 PHY if 10/100 only

[Caleb James DeLisle]

On 18/09/2026 18:29, Andrew Lunn wrote:
> On Fri, Sep 18, 2026 at 04:11:56PM +0000, Caleb James DeLisle wrote:
> > An EcoNet SoC 10/100 PHY uses the same ID as the MT7530 PHY, but a true
> > MT7530 PHY always has gigabit support so they can be distinguished by
> > the presence of the ESTATUS_1000_TFULL flag. Add a match_phy_device
> > which refuses to match if the PHY is not gigabit.
> Don't you also need the opposite in mtk-fe-soc.c? Otherwise don't you
> rely on the load order of the PHY drivers?

The collision is in econet-fe-soc.c of 
https://lore.kernel.org/netdev/20260827065930.2618729-3-cjd@xxxxxxxx/

And I notice now that I did add it in that patchset as well, but this 
implementation is better done and that patchset is probably going to 
have a v2 so I think it's better to accept it here.

Thanks,

Caleb

>      Andrew
>
> ---
> pw-bot: cr