Re: [PATCH] platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables

[Ilpo Järvinen]

On Wed, 26 Aug 2026, Huang Wei wrote:

> The Lenovo ThinkPad X9-14 Gen 1 uses a non-standard Embedded Controller
> firmware (ECFW) whose thermal and fan registers are not located at the
> classic addresses. On this model the thermal registers sit at 0xA8-0xAF /
> 0xB8-0xBF and the fan registers use the non-standard offsets, instead of
> the legacy 0x78-0x7F / 0xC0-0xC7 (thermal) and 0x2f / 0x84 (fan).
> 
> Because the model is not covered by the existing quirk tables, the driver
> probes the legacy thermal addresses during init, reads back 0x00 from
> every register, concludes the EC is "misbehaving" and disables all
> thermal sensor access:
> 
>   thinkpad_acpi: ThinkPad ACPI EC access misbehaving, disabling thermal
>   sensors access
> 
> Fan access is affected the same way, leaving fan1/fan2 reporting 0 RPM.
> 
> The infrastructure for these non-standard ECFW models is already in place
> (commit 301c1904d638 ("platform/x86: thinkpad_acpi: Fix to correct wrong
> temp reporting on some ThinkPads")); the X9-14 Gen 1 simply was not added
> to the model lists yet. Add its BIOS model code N4D to both the thermal
> and fan quirk tables so that:
>   - thermal_read_mode_check() selects TPACPI_THERMAL_TPEC_12 and reads
>     the 0xA8/0xB8 registers, and
>   - fan_init() selects the non-standard fan register addresses.
> 
> Reported-by: thisisamirv <thisisamirv@xxxxxxxxx>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221228
> Signed-off-by: Huang Wei <huangwei@xxxxxxxxxx>
> ---
>  drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 6dd7c28fc0db..498139ac8f4b 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -6021,6 +6021,7 @@ static const struct tpacpi_quirk thermal_quirk_table[] __initconst = {
>  	TPACPI_Q_LNV3('R', '0', 'T', true),	/* 11e Gen5 GL*/
>  	TPACPI_Q_LNV3('R', '1', 'D', true),	/* 11e Gen5 GL-R*/
>  	TPACPI_Q_LNV3('R', '0', 'V', true),	/* 11e Gen5 KL-Y*/
> +	TPACPI_Q_LNV3('N', '4', 'D', true),	/* X9-14 Gen 1 */
>  };
>  
>  static enum thermal_access_mode thermal_read_mode;
> @@ -8845,6 +8846,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
>  	TPACPI_Q_LNV3('R', '0', 'T', TPACPI_FAN_NS),	/* 11e Gen5 GL */
>  	TPACPI_Q_LNV3('R', '1', 'D', TPACPI_FAN_NS),	/* 11e Gen5 GL-R */
>  	TPACPI_Q_LNV3('R', '0', 'V', TPACPI_FAN_NS),	/* 11e Gen5 KL-Y */
> +	TPACPI_Q_LNV3('N', '4', 'D', TPACPI_FAN_NS),	/* X9-14 Gen 1 */
>  	TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN),	/* X1 Tablet (2nd gen) */
>  	TPACPI_Q_LNV3('R', '0', 'Q', TPACPI_FAN_DECRPM),/* L480 */
>  	TPACPI_Q_LNV('8', 'F', TPACPI_FAN_TPR),		/* ThinkPad x120e */

Hi,

This no longer applies cleanly so please respin.


-- 
 i.