Re: [PATCH v2 2/3] dt-bindings: usb: Introduce samsung,snps-dwc3

[Krzysztof Kozlowski]

On 18/09/2026 15:46, Krzysztof Kozlowski wrote:
> On 18/09/2026 15:36, Selvarasu Ganesan wrote:
> 
>>
>> As seen in samsung,exynos-dwc3.yaml, our existing bindings already 
>> support multiple SoCs with diverse clock requirements within a single 
>> file. Similarly, we plan to use a single flattened Samsung binding to 
>> manage these diverse clock requirements. for different SoCs.
>>
>> Regarding the migration for current and future SoCs, would you prefer,
> 
> I do not understand how any of this is relevant to my review comment.
> 
>>
>> Option A: A single flattened binding file using a common fallback 
>> compatible string (instead of samsung,snps-dwc3) to minimize 
>> of_match_table entries, and if/then constraints to handle diverse clock 
>> requirements.
>> Option B: Separate binding files for each individual SoCs.
>>
>> Could you please let us know your preferred approach? Once confirmed, we 
>> will address your other review comments based on the selected approach.
> 
> You do not have other bindings. You have one device. If you have more,
> then post more. We are not making reviews based on imaginary future things.

OK, I guess you referred to my further comments about if:then: block
here. When you have more devices, you can add them to the same binding,
with proper constraints for each variant.

https://elixir.bootlin.com/linux/v7.3-rc3/source/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml#L93

If the difference is only in clocks, one binding file is usually good to
hold many variants. If there are more differences, things are getting
too messy and more files are useful (see commit
c80dc8121d3af8f33413bb0f9ed9e81e2c576e1a for example).

Best regards,
Krzysztof