Re: [PATCH v4 3/3] arm64: dts: qcom: sm7325-xiaomi-taoyao: switch to device-specific pmic-glink compatible

[Stanislav Zaikin]

On 9/17/26 1:31 PM, Konrad Dybcio wrote:
> On 9/15/26 10:49 AM, Stanislav Zaikin wrote:
> > Switch taoyao to "xiaomi,taoyao-pmic-glink" compatible so
> > qcom_battmgr can identify the device and apply its taoyao-specific
> > battery property mapping, required because its firmware shifts
> > battery property IDs relative to the generic sm7325-pmic-glink
> > firmware.
> >
> > Signed-off-by: Stanislav Zaikin <zstaseg@xxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
> > index 6f8bc65bb99b..bc4dfa49ef38 100644
> > --- a/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
> > @@ -72,7 +72,7 @@ key-volume-up {
> >   	};
> >   
> >   	pmic-glink {
> > -		compatible = "qcom,sm7325-pmic-glink",
> > +		compatible = "xiaomi,taoyao-pmic-glink",
> >   			     "qcom,qcm6490-pmic-glink",
> >   			     "qcom,pmic-glink";
>
> As krzk points out, this should be a standalone single compatible,
> because it's neither going to work with qcm6490-pmic-glink nor with
> qcom,pmic-glink
>
> Konrad

Only the battmgr implementation differs but the rest is compatible with 
qcm6490 (UCSI implementation) and generic pmic-glink (basic 
communication). So, we should keep all 3 compatibles.

--
Best regards,
Stanislav