Re: [PATCH 2/2] drm/tiny: Add RAiO RA8875 display controller driver

[Krzysztof Kozlowski]

On Thu, Sep 17, 2026 at 02:04:10AM +0800, Adam Azuddin wrote:
> +static const struct drm_connector_helper_funcs ra8875_connector_helper_funcs = {
> +	.get_modes = ra8875_connector_get_modes
> +};
> +
> +static const struct of_device_id ra8875_of_match[] = {
> +	{ .compatible = "raio,ra8875" },
> +	{},

Drop ,. Missing space. Please look at other files how this is written,
because it was a cleanup some time ago.

> +};
> +

No blank line.

> +MODULE_DEVICE_TABLE(of, ra8875_of_match);

All ID tables are placed together, just before 'struct xxx_driver'.

> +
> +static int ra8875_write_reg(struct ra8875_device *ra8875, u8 reg, u8 val)
> +{
> +	int ret;
> +	u8 cmd[2] = { 0x80, reg };
> +	u8 data[2] = { 0x00, val };
> +

...

> +
> +static void ra8875_display_off(struct ra8875_device *ra8875)
> +{
> +	drm_atomic_helper_shutdown(&ra8875->drm); /* calls pipe_disable above */
> +}
> +
> +static const u32 ra8875_pipe_formats[] = {
> +	DRM_FORMAT_RGB565,
> +};
> +
> +static const struct drm_simple_display_pipe_funcs ra8875_pipe_funcs = {
> +	.enable = ra8875_pipe_enable,
> +	.disable = ra8875_pipe_disable,
> +	.update = ra8875_pipe_update,
> +	DRM_GEM_SIMPLE_DISPLAY_PIPE_SHADOW_PLANE_FUNCS,
> +};
> +
> +static const struct spi_device_id ra8875_id[] = { { "ra8875", 0 }, {} };

This is completely misformatted table. Please open other files.
git grep 'struct spi_device_id'

> +
> +MODULE_DEVICE_TABLE(spi, ra8875_id);

Best regards,
Krzysztof