Re: [PATCH v2 01/19] dt-bindings: clock: qcom: Add MSM8952 global clock controller
From: Krzysztof Kozlowski
Date: Fri Sep 18 2026 - 06:11:53 EST
On Wed, Sep 16, 2026 at 05:22:06PM +0300, Muzaffer Kadir wrote:
> Add a device tree binding to describe clocks, resets and power domains
> provided by the global clock controller on MSM8952 SoC.
>
> Signed-off-by: Muzaffer Kadir <muzafferkadir@xxxxxxxxxxxxxx>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
> ---
> .../bindings/clock/qcom,gcc-msm8952.yaml | 56 ++++++
> include/dt-bindings/clock/qcom,gcc-msm8952.h | 217 +++++++++++++++++++++
> 2 files changed, 273 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml
> new file mode 100644
> index 000000000000..274dde633e17
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8952.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8952.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller on MSM8952
> +
> +maintainers:
> + - Muzaffer Kadir <muzafferkadir@xxxxxxxxxxxxxx>
> +
> +description: |
> + Qualcomm global clock control module provides the clocks, resets and power
> + domains on MSM8952.
> +
> + See also::
git grep "also::" -- Documentation/devicetree/bindings/clock/
I asked you month ago here:
<e3fb3794-ca7a-4794-8036-b69e563aaa57@xxxxxxxxxx>
to not work on old forks.
Old fork which you should not use is postmarketos, lineageos, whatever
Android fork kernel, and whatever other tree which is not upstream from
kernel.org.
Best regards,
Krzysztof