Re: [PATCH] crypto: zynqmp-sha - fix NULL pointer dereference in init_tfm
From: Herbert Xu
Date: Fri Sep 18 2026 - 05:59:24 EST
On Tue, Sep 08, 2026 at 09:53:40AM +0200, Thorsten Blum wrote:
> zynqmp_sha_init_tfm() checks crypto_shash_statesize(tfm_ctx->fbk_tfm)
> before assigning the fallback transform to it, which dereferences a NULL
> pointer since the transform context is zero-initialized. Use the local
> fallback_tfm pointer for the size check instead.
>
> Fixes: c1dd353d18e5 ("crypto: zynqmp-sha - Make descsize an algorithm attribute")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
> ---
> drivers/crypto/xilinx/zynqmp-sha.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt