Re: [PATCH v7 03/11] iio: dac: mcp47feb02: use field_get() instead of custom dynamic macros

From: Andy Shevchenko

Date: Fri Sep 18 2026 - 05:54:39 EST


On Fri, Sep 18, 2026 at 12:06:29PM +0300, Ariana Lazar wrote:
> Replace manual bit operations which select channel corresponding bits
> from a control register in mcp47feb02_init_ctrl_regs() with field_get()
> macro used with masks already defined for regmap operations within the
> driver.

> Suggested-by: Jonathan Cameron <jic23@xxxxxxxxxx>

> Link: https://lore.kernel.org/all/20260913224339.490d89ba@jic23-hlaptop/

No need a Link tag for the simple suggestion. I believe there no any unobvious
things that were discussed at that Link.

> Signed-off-by: Ariana Lazar <ariana.lazar@xxxxxxxxxxxxx>

Also this is not a fix, move it towards the tail of the series.

--
With Best Regards,
Andy Shevchenko