Re: [PATCH] power: supply: qcom_smbx: Remove const from desc allocation type

From: Konrad Dybcio

Date: Fri Sep 18 2026 - 04:02:44 EST


On 9/17/26 11:13 PM, Kees Cook wrote:
> From: Kees Cook <kees+treewide@xxxxxxxxxx>
>
> In preparation for making the devm_kmalloc family of allocators type
> aware, we need to make sure that the returned type from the allocation
> matches the type of the variable being assigned. (Before, the allocator
> would always return "void *", which can be implicitly cast to any
> pointer type.)
>
> The assigned type is "struct power_supply_desc *", but the converted
> allocation type would be "const struct power_supply_desc *", as the size
> was taken from "smb_psy_desc", which is a
> "static const struct power_supply_desc". As there is no general way to
> remove const qualifiers, take the size from the assignment target
> instead. No change in allocation size results.
>
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> drivers/power/supply/qcom_smbx.o
>
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@xxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad