Re: [PATCH v11 0/9] media: iris: Add support for glymur platform

[Krzysztof Kozlowski]

On 18/09/2026 08:57, Vishnu Reddy wrote:
> 
> On 9/17/2026 12:41 PM, Krzysztof Kozlowski wrote:
>> On 17/09/2026 09:09, Krzysztof Kozlowski wrote:
>>> On Thu, Sep 17, 2026 at 10:30:19AM +0530, Vishnu Reddy wrote:
>>>> ---
>>>> Mukesh Ojha (1):
>>>>       media: iris: Enable Secure PAS support with IOMMU managed by Linux
>>>>
>>>> Vishnu Reddy (8):
>>>>       dt-bindings: media: qcom,glymur-iris: Add glymur video codec
>>>>       media: iris: Replace enum-indexed clock and power domain tables with per-block structures
>>>>       media: iris: Add power sequence for glymur
>>>>       media: iris: Handle CPU_CS_SCIACMDARG3 register write via program bootup registers hook
>>>>       media: iris: Add support to select core for dual core platforms
>>>>       media: iris: Add platform data for glymur
>>>>       arm64: dts: qcom: glymur: Add iris video node
>>>>       arm64: dts: qcom: glymur-crd: Enable iris video codec node
>>>>
>>>>  .../bindings/media/qcom,glymur-iris.yaml           | 218 +++++++++++++++++++++
>>>>  .../bindings/media/qcom,sm8550-iris.yaml           |   6 +
>>>>  .../bindings/media/qcom,sm8750-iris.yaml           |   6 +
>>>>  .../bindings/media/qcom,venus-common.yaml          |  11 +-
>>>>  arch/arm64/boot/dts/qcom/glymur-crd.dtsi           |  10 +
>>>>  arch/arm64/boot/dts/qcom/glymur.dtsi               | 120 ++++++++++++
>>>>  drivers/media/platform/qcom/iris/Makefile          |   1 +
>>>>  drivers/media/platform/qcom/iris/iris_common.c     |  10 +
>>>>  drivers/media/platform/qcom/iris/iris_common.h     |   1 +
>>>>  drivers/media/platform/qcom/iris/iris_core.h       |  32 ++-
>>>>  drivers/media/platform/qcom/iris/iris_firmware.c   |  69 +++++--
>>>>  drivers/media/platform/qcom/iris/iris_hfi_common.h |   1 +
>>>>  .../platform/qcom/iris/iris_hfi_gen2_command.c     |  19 ++
>>>>  .../platform/qcom/iris/iris_hfi_gen2_defines.h     |   1 +
>>>>  drivers/media/platform/qcom/iris/iris_instance.h   |   2 +
>>>>  .../platform/qcom/iris/iris_platform_common.h      |  46 ++---
>>>>  .../platform/qcom/iris/iris_platform_glymur.c      |  78 ++++++++
>>>>  .../platform/qcom/iris/iris_platform_glymur.h      |  15 ++
>>>>  .../platform/qcom/iris/iris_platform_sc7280.h      |  28 ++-
>>>>  .../platform/qcom/iris/iris_platform_sm8250.h      |  26 ++-
>>>>  .../platform/qcom/iris/iris_platform_sm8550.h      |  26 ++-
>>>>  .../platform/qcom/iris/iris_platform_sm8750.h      |  29 ++-
>>>>  .../media/platform/qcom/iris/iris_platform_vpu2.c  |  20 +-
>>>>  .../media/platform/qcom/iris/iris_platform_vpu3x.c |  67 ++++---
>>>>  .../platform/qcom/iris/iris_platform_x1p42100.h    |  27 ++-
>>>>  drivers/media/platform/qcom/iris/iris_power.c      |  20 +-
>>>>  drivers/media/platform/qcom/iris/iris_probe.c      | 153 +++++++++++++--
>>>>  drivers/media/platform/qcom/iris/iris_resources.c  |  81 ++++----
>>>>  drivers/media/platform/qcom/iris/iris_resources.h  |   8 +-
>>>>  drivers/media/platform/qcom/iris/iris_utils.c      |  58 ++++--
>>>>  drivers/media/platform/qcom/iris/iris_utils.h      |   3 +-
>>>>  drivers/media/platform/qcom/iris/iris_vb2.c        |   4 +
>>>>  drivers/media/platform/qcom/iris/iris_vidc.c       |   6 +-
>>>>  drivers/media/platform/qcom/iris/iris_vpu3x.c      | 216 +++++++++++++++++---
>>>>  drivers/media/platform/qcom/iris/iris_vpu4x.c      | 137 ++-----------
>>>>  drivers/media/platform/qcom/iris/iris_vpu_common.c | 102 ++--------
>>>>  drivers/media/platform/qcom/iris/iris_vpu_common.h |   3 +
>>>>  .../platform/qcom/iris/iris_vpu_register_defines.h |  13 ++
>>>>  38 files changed, 1229 insertions(+), 444 deletions(-)
>>>> ---
>>>> base-commit: 0d9d0dbf2fddcff5859d623e90ca73c4054276e1
>>>> change-id: 20260917-glymur-627d049900e0
>>> Look here:
>>> https://lore.kernel.org/all/20260726-glymur-v10-0-de451559e88b@xxxxxxxxxxxxxxxx/
>>> change-id: 20260601-glymur-4fcd4d832ecc
>>>
>>> so now does this work?
>>> 	b4 diff '20260917-glymur-v11-1-e0c8bc914742@xxxxxxxxxxxxxxxx'
>>>
>>> No, it does not. You are sending bigger work, multi-version one, part of
>>> even bigger work, so please get the process working correct to make
>>> reviews easier.
>>>
>> And it is getting even better:
>> v6 change id was:
>> 	change-id: 20260515-glymur-6e69bc258fb0
>>
>> https://lore.kernel.org/all/20260515-glymur-v6-0-f6a99cb43a24@xxxxxxxxxxxxxxxx/
>>
>> ???
> 
> Thank you for pointing this out. I lost my original workspace and had to
> recreate it, which unintentionally changed the Change-ID. I'll make sure
> to preserve the same Change-ID in further revisions.

You lost workspace three or four times? Go look at your previous
versions and count how many different change-ids there were...

Best regards,
Krzysztof